Skip to content

Change pre-commit propety(v1)#53636

Merged
potiuk merged 1 commit intoapache:mainfrom
kyungjunleeme:fix/ci_static_check_align
Jul 24, 2025
Merged

Change pre-commit propety(v1)#53636
potiuk merged 1 commit intoapache:mainfrom
kyungjunleeme:fix/ci_static_check_align

Conversation

@kyungjunleeme
Copy link
Contributor

@kyungjunleeme kyungjunleeme commented Jul 22, 2025 •
edited
Loading

  • pre-commit hook only include v1.yaml

it solve ci error in github.
related #53597

It cause error. refer to below image.

image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jul 22, 2025
@kyungjunleeme kyungjunleeme mentioned this pull request Jul 22, 2025
Merged
@potiuk
Copy link
Member

potiuk commented Jul 22, 2025

What problem does it solve really ?

@kyungjunleeme
Copy link
Contributor Author

kyungjunleeme commented Jul 23, 2025

I realized that while I updated the API, I missed the corresponding frontend changes. Unfortunately, I wasn't able to reproduce the issue on my side, but I should have been more careful before submitting the PR. I sincerely apologize for the oversight. I’ll make the necessary adjustments and prepare an updated version for review soon. I also want to acknowledge that I didn’t fully consider how valuable your time as a reviewer is—I'm truly sorry for that.

@kyungjunleeme kyungjunleeme marked this pull request as draft July 23, 2025 10:38
@potiuk
Copy link
Member

potiuk commented Jul 23, 2025

I realized that while I updated the API, I missed the corresponding frontend changes. Unfortunately, I wasn't able to reproduce the issue on my side, but I should have been more careful before submitting the PR. I sincerely apologize for the oversight. I’ll make the necessary adjustments and prepare an updated version for review soon. I also want to acknowledge that I didn’t fully consider how valuable your time as a reviewer is—I'm truly sorry for that.

No worries - I was just wondering what's wrong there :)

@kyungjunleeme
Copy link
Contributor Author

kyungjunleeme commented Jul 24, 2025 •
edited
Loading

What problem does it solve really ?

The current files pattern only matches:

^airflow-core/src/airflow/api_fastapi/auth/managers/simple/openapi/v1.*\.yaml$

so it doesn't catch changes like v2-simple-auth-manager-generated.yaml.
I'm planning to update the regex to:

^airflow-core/src/airflow/api_fastapi/auth/managers/simple/openapi/.*\.yaml$

to ensure all OpenAPI changes under the simple/openapi/ directory are properly detected by pre-commit.

There is an issue with the pre-commit scope, which is causing the following failure:

https://github.com/apache/airflow/actions/runs/16489362751/job/46620971120

@kyungjunleeme kyungjunleeme force-pushed the fix/ci_static_check_align branch from b5890a3 to 69a1daf Compare July 24, 2025 07:16
@kyungjunleeme kyungjunleeme marked this pull request as ready for review July 24, 2025 07:17
@kyungjunleeme kyungjunleeme force-pushed the fix/ci_static_check_align branch from 69a1daf to 7712f5c Compare July 24, 2025 07:17
@kyungjunleeme kyungjunleeme changed the title Align Ci static Check Change pre-commit propety(v1) Jul 24, 2025
@kyungjunleeme kyungjunleeme force-pushed the fix/ci_static_check_align branch from 7712f5c to 5774ab6 Compare July 24, 2025 10:26
@potiuk potiuk merged commit 9d9924e into apache:main Jul 24, 2025
56 checks passed
@potiuk
Copy link
Member

potiuk commented Jul 24, 2025

Cool

@potiuk
Copy link
Member

potiuk commented Jul 24, 2025

Now it makes sense :)

github-actions bot pushed a commit that referenced this pull request Jul 24, 2025
@kyungjunleeme
[v3-0-test] CHG: cover v1, v2 (#53636)
21c1f5b 
(cherry picked from commit 9d9924e)

Co-authored-by: Kyungjun Lee <kyungjunlee.me@gmail.com>
@github-actions
Copy link

github-actions bot commented Jul 24, 2025

Backport successfully created: v3-0-test

Status Branch Result
✅ v3-0-test PR Link

potiuk pushed a commit that referenced this pull request Jul 24, 2025
@github-actions @kyungjunleeme
[v3-0-test] CHG: cover v1, v2 (#53636) (#53709)
231129f 
(cherry picked from commit 9d9924e)

Co-authored-by: Kyungjun Lee <kyungjunlee.me@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@ashb ashb Awaiting requested review from ashb

@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan

Assignees

No one assigned

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kyungjunleeme @potiuk